]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: fix abbrev selection for output params
authorThan McIntosh <thanm@google.com>
Fri, 30 Apr 2021 15:15:44 +0000 (11:15 -0400)
committerThan McIntosh <thanm@google.com>
Fri, 30 Apr 2021 19:38:51 +0000 (19:38 +0000)
commit41afd3af42bd8028a1740c30a2b745105b4063d2
treee732b55b6b865d58b388cf7c4a553ec558163a20
parentd19eece91f7825556eadfef08e7011e22a719ec0
cmd/compile: fix abbrev selection for output params

In Cl 302071 we changed the compiler to use a different recipe for
selecting the DWARF frame offset for output parameters, to reflect the
fact that registerized output params don't have a stack memory
location on entry to the function. In the process, however, we
switched from using an abbrev pf DW_ABRV_PARAM to an abbrev of
DW_ABRV_AUTO, which means that Delve can't recognize them correctly.
To fix the problem, switch back to picking the correct abbrev entry,
while leaving the new offset recipe intact.

Updates #40724.
Updates #45720.

Change-Id: If721c9255bcd030177806576cde3450563f7a235
Reviewed-on: https://go-review.googlesource.com/c/go/+/315610
Trust: Than McIntosh <thanm@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/cmd/compile/internal/dwarfgen/dwarf.go
src/cmd/link/internal/ld/dwarf_test.go