]> Cypherpunks repositories - gostls13.git/commit
runtime, reflect: use correctly aligned stack frame sizes on arm64
authorRuss Cox <rsc@golang.org>
Wed, 29 Jul 2015 19:04:30 +0000 (15:04 -0400)
committerRuss Cox <rsc@golang.org>
Wed, 29 Jul 2015 21:35:35 +0000 (21:35 +0000)
commit421220571d1ae7c78131f8a01ea3d5aca6a92160
treebd82ee8929baa6039e41a429fbacbbcd279dbae7
parent3952057cf6597981efcc066349fcfae746333f83
runtime, reflect: use correctly aligned stack frame sizes on arm64

arm64 requires either no stack frame or a frame with a size that is 8 mod 16
(adding the saved LR will make it 16-aligned).

The cmd/internal/obj/arm64 has been silently aligning frames, but it led to
a terrible bug when the compiler and obj disagreed on the frame size,
and it's just generally confusing, so we're going to make misaligned frames
an error instead of something that is silently changed.

This CL prepares by updating assembly files.
Note that the changes in this CL are already being done silently by
cmd/internal/obj/arm64, so there is no semantic effect here,
just a clarity effect.

For #9880.

Change-Id: Ibd6928dc5fdcd896c2bacd0291bf26b364591e28
Reviewed-on: https://go-review.googlesource.com/12845
Reviewed-by: Austin Clements <austin@google.com>
src/reflect/asm_arm64.s
src/runtime/asm_arm64.s
src/runtime/sys_linux_arm64.s