]> Cypherpunks repositories - gostls13.git/commit
cmd/go: refine definition of 'standard' import paths to include vendored code
authorRuss Cox <rsc@golang.org>
Wed, 27 Jan 2016 15:05:18 +0000 (10:05 -0500)
committerRuss Cox <rsc@golang.org>
Wed, 27 Jan 2016 18:03:15 +0000 (18:03 +0000)
commit4223675913762a12cd23871fbd003d8a68cb49a1
treefcac590bd8acce00c28592540cbd313734ecedf0
parent1023d63f7f0ee31f5810e3e5598227c85442a1e2
cmd/go: refine definition of 'standard' import paths to include vendored code

The vendored copy of golang.org/x/net/http/hpack was being treated
as not standard, which in turn was making it not subject to the mtime
exception for rebuilding the standard library in a release, which in turn
was making net/http look out of date.

One fix and three tests:

- Fix the definition of standard.
- Test that everything in $GOROOT/src/ is standard during 'go test cmd/go'.
(In general there can be non-standard things in $GOROOT/src/, but this
test implies that you can do that or you can run 'go test cmd/go',
but not both. That's fine.)
- Test that 'go list std cmd' shows our vendored code.
- Enforce that no standard package can depend on a non-standard one.

Also fix a few error printing nits.

Fixes #13713.

Change-Id: I1f943f1c354174c199e9b52075c11ee44198e81b
Reviewed-on: https://go-review.googlesource.com/18978
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
src/cmd/go/go_test.go
src/cmd/go/main.go
src/cmd/go/pkg.go
src/cmd/go/run.go