]> Cypherpunks repositories - gostls13.git/commit
sync/atomic: fix unimportant assembly errors found by go vet
authorRuss Cox <rsc@golang.org>
Thu, 15 May 2014 20:31:20 +0000 (16:31 -0400)
committerRuss Cox <rsc@golang.org>
Thu, 15 May 2014 20:31:20 +0000 (16:31 -0400)
commit42ea2eda4902469fc15be067ee4e0becfae27ec4
treee6480cf2e6013d5d225abd305671fa2129ed6197
parent208a1ea564e8b1ce8d6d85a315a410f29d5e952e
sync/atomic: fix unimportant assembly errors found by go vet

None of these are real bugs.
The variable name in the reference is not semantically meaningful,
except that 'go vet' will double check the offset against the name for you.

The stack sizes being corrected really are incorrect but they are also
in NOSPLIT functions so they typically don't matter.

Found by vet.

GOOS=linux GOARCH=amd64 go vet sync/atomic
GOOS=linux GOARCH=amd64p32 go vet sync/atomic
GOOS=linux GOARCH=386 go vet sync/atomic
GOOS=linux GOARCH=arm go vet sync/atomic
GOOS=freebsd GOARCH=arm go vet sync/atomic
GOOS=netbsd GOARCH=arm go vet sync/atomic

LGTM=r
R=r, bradfitz
CC=golang-codereviews
https://golang.org/cl/100500043
src/pkg/sync/atomic/asm_386.s
src/pkg/sync/atomic/asm_amd64.s
src/pkg/sync/atomic/asm_amd64p32.s
src/pkg/sync/atomic/asm_linux_arm.s
src/pkg/sync/atomic/export_linux_arm_test.go