]> Cypherpunks repositories - gostls13.git/commit
cmd/compile/internal/gc: reword "declared and not used" error message
authorShenghou Ma <minux@golang.org>
Fri, 25 Oct 2019 01:29:30 +0000 (21:29 -0400)
committerRobert Griesemer <gri@golang.org>
Mon, 28 Oct 2019 23:34:13 +0000 (23:34 +0000)
commit449b6abbacc464443a7faf166bf4db3df3e0f8da
treef171c30ee234dd58962d21b47c773db1b2c85aff
parentbf670bd83c849b56426c63b49f28121210a627ca
cmd/compile/internal/gc: reword "declared and not used" error message

"declared and not used" is technically correct, but might confuse
the user. Switching "and" to "but" will hopefully create the
contrast for the users: they did one thing (declaration), but
not the other --- actually using the variable.

This new message is still not ideal (specifically, declared is not
entirely precise here), but at least it matches the other parsers
and is one step in the right direction.

Change-Id: I725c7c663535f9ab9725c4b0bf35b4fa74b0eb20
Reviewed-on: https://go-review.googlesource.com/c/go/+/203282
Run-TryBot: Minux Ma <minux@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/internal/gc/swt.go
src/cmd/compile/internal/gc/walk.go
test/fixedbugs/bug373.go
test/fixedbugs/issue21317.go
test/fixedbugs/issue23116.go
test/fixedbugs/issue29870b.go
test/typeswitch2b.go