]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: fix write barrier coalescing
authorKeith Randall <khr@golang.org>
Sat, 11 Jan 2025 01:33:26 +0000 (17:33 -0800)
committerKeith Randall <khr@golang.org>
Mon, 13 Jan 2025 06:49:39 +0000 (22:49 -0800)
commit44a6f817ea0fbeb3ba4aa398794c4e80dba13b1e
treebf8b97d89a07f0185ab42468d20b2e68887f4986
parent19e923182e590ae6568c2c714f20f32512aeb3e3
cmd/compile: fix write barrier coalescing

We can't coalesce a non-WB store with a subsequent Move, as the
result of the store might be the source of the move.

There's a simple codegen test. Not sure how we might do a real test,
as all the repro's I've come up with are very expensive and unreliable.

Fixes #71228

Change-Id: If18bf181a266b9b90964e2591cd2e61a7168371c
Reviewed-on: https://go-review.googlesource.com/c/go/+/642197
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drchase@google.com>
src/cmd/compile/internal/ssa/writebarrier.go
test/codegen/writebarrier.go