]> Cypherpunks repositories - gostls13.git/commit
cmd/dist: skip non-race tests
authorAustin Clements <austin@google.com>
Thu, 17 Nov 2022 01:58:38 +0000 (20:58 -0500)
committerGopher Robot <gobot@golang.org>
Thu, 17 Nov 2022 02:58:30 +0000 (02:58 +0000)
commit44edc5d78740ab702bb782b5e4533f6dee07ad78
treec16ebbb2d78080e8ebf3fa84c6d4d6ff15e7bb0b
parent3f5b02d09f0d345c2d6bef83eddbd518e9327276
cmd/dist: skip non-race tests

In -race mode, the dist test command only registers the std, race,
osusergo, and amd64ios tests before returning early from
(*tester).registerTests. Prior to CL 450018, the osusergo and amd64ios
tests weren't even affected by -race mode, so it seems their inclusion
was unintentional. CL 450018 lifted the logic to run tests in race
mode, which means these tests went from running without -race to
running with -race. Unfortunately, amd64ios is not compatible with
-race, so it is now failing on the darwin-amd64-race builder.

Fix this by omitting the osusergo and amd64ios tests from -race mode,
since it seems like they were really intended to be included anyway.

This should fix the darwin-amd64-race builder.

Updates #37486.

Change-Id: I554bb60bc729dbb6f1bc926f1ea329768b0d6d81
Reviewed-on: https://go-review.googlesource.com/c/go/+/451437
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Austin Clements <austin@google.com>
src/cmd/dist/test.go