]> Cypherpunks repositories - gostls13.git/commit
runtime, internal/poll: report only critical event scanning error
authorMikio Hara <mikioh.public.networking@gmail.com>
Thu, 14 Mar 2019 20:10:08 +0000 (05:10 +0900)
committerMikio Hara <mikioh.public.networking@gmail.com>
Tue, 19 Mar 2019 08:30:50 +0000 (08:30 +0000)
commit451a2eb0abf38874fb144963a44356495141465d
treec8299d003a9527ff02494d6faddbce5a2f562e1c
parentd24d25b4e43badc38539b563f5264b341ccf3746
runtime, internal/poll: report only critical event scanning error

This change makes the runtime-integrated network poller report only
critical event scanning errors.

In the previous attempt, CL 166497, we treated any combination of error
events as event scanning errors and it caused false positives in event
waiters because platform-dependent event notification mechanisms allow
event originators to use various combination of events.

To avoid false positives, this change makes the poller treat an
individual error event as a critical event scanning error by the
convention of event notification mechanism implementations.

Updates #30624.
Fixes #30817.
Fixes #30840.

Change-Id: I906c9e83864527ff73f636fd02bab854d54684ea
Reviewed-on: https://go-review.googlesource.com/c/go/+/167777
Run-TryBot: Mikio Hara <mikioh.public.networking@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/internal/poll/error_test.go
src/internal/poll/read_test.go [new file with mode: 0644]
src/runtime/netpoll_aix.go
src/runtime/netpoll_epoll.go
src/runtime/netpoll_kqueue.go
src/runtime/netpoll_solaris.go