]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.12] cmd/go: force -coverpkg main packages to be built as libraries
authorJay Conrod <jayconrod@google.com>
Fri, 10 May 2019 15:49:08 +0000 (11:49 -0400)
committerDmitri Shuralyov <dmitshur@golang.org>
Fri, 7 Jun 2019 22:33:16 +0000 (22:33 +0000)
commit451e6d61b375ed8b7d2411af9514df12e9970d45
tree839ffd3881387c1a23a04862946cff0ecdee818e
parent918368e46c53e716f6c4137c174f19d9a907f887
[release-branch.go1.12] cmd/go: force -coverpkg main packages to be built as libraries

This fixes TestScript/cover_pkgall_multiple_mains, which started
failing after CL 174657.

When compiling main packages with coverage instrumentation
(e.g., for -coverpkg all), we now pass -p with the full import path
instead of '-p main'. This avoids link errors
'duplicate symbol main.main (types 1 and 1)'.

Fixes #32295
Updates #31946
Updates #32150

Change-Id: Id147527b1dbdc14bb33ac133c30d50c250b4365c
Reviewed-on: https://go-review.googlesource.com/c/go/+/176558
Run-TryBot: Jay Conrod <jayconrod@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 3b8c804164e26bdec6ca94a5ab1b5c35fa119e5e)
Reviewed-on: https://go-review.googlesource.com/c/go/+/179677
src/cmd/go/internal/load/test.go