]> Cypherpunks repositories - gostls13.git/commit
runtime: soften up the GCTestIsReachable test a bit
authorKeith Randall <khr@golang.org>
Tue, 4 Jun 2024 21:54:55 +0000 (14:54 -0700)
committerKeith Randall <khr@google.com>
Wed, 5 Jun 2024 22:33:52 +0000 (22:33 +0000)
commit45967bb18e04fa6dc62c2786c87ce120443c64f6
tree4a7cc24e6c8c15a1a7a30d6ec3c13b0e163ac368
parent7274921681d1ddf4d3246b0c92f0d6d6580afc7a
runtime: soften up the GCTestIsReachable test a bit

This test can fail due to objects being incorrectly retained due
to conservative scanning. Allow a bit of slop (1 accidentally
retained object) to prevent flaky failures.

Fixes #67204

"fixes" is a bit too strong a word. More like, hopefully reduces
the false positive rate to something approaching 0.

Change-Id: I09984f0cce50d8209aef19f3d89b0e295c86f8d1
Reviewed-on: https://go-review.googlesource.com/c/go/+/590615
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/runtime/gc_test.go