]> Cypherpunks repositories - gostls13.git/commit
cmd/link: handle STT_COMMON symbols
authorIan Lance Taylor <iant@golang.org>
Tue, 29 Nov 2016 00:19:03 +0000 (16:19 -0800)
committerIan Lance Taylor <iant@golang.org>
Tue, 29 Nov 2016 02:15:04 +0000 (02:15 +0000)
commit45f759500ec80a1362deecd3693cbe44a354bf98
tree2c622c2415dbca137e497430d91ea4b0c9f3b91b
parent610d522189ed3fcf0d298609a248a3283bde62cd
cmd/link: handle STT_COMMON symbols

Tested by running

GOTRACEBACK=2 CGO_CFLAGS="-Wa,--elf-stt-common=yes" go test -ldflags=-linkmode=internal

in misc/cgo/test. That failed before this CL, succeeded after.

I don't think it's worth doing that as a regular test, though,
especially since only recent versions of the GNU binutils support the
--elf-stt-common option.

Fixes #18088.

Change-Id: I893d86181faee217b1504c054b0ed3f7c8d977d3
Reviewed-on: https://go-review.googlesource.com/33653
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/link/internal/ld/ldelf.go