]> Cypherpunks repositories - gostls13.git/commit
misc: remove use of relative directories in overlayDir functions
authorBryan C. Mills <bcmills@google.com>
Fri, 22 Nov 2019 21:06:11 +0000 (16:06 -0500)
committerBryan C. Mills <bcmills@google.com>
Mon, 25 Nov 2019 16:26:15 +0000 (16:26 +0000)
commit476395cb3e97cf7d9c50d8fe57c2c7926f1cff48
tree4e04d5e7f73e1e15abd63658cc947f6ac4adbd3e
parent01f15b62b3d91c0f7fed54eedeee4123eb04b533
misc: remove use of relative directories in overlayDir functions

It turns out that the relative-path support never worked in the first
place.

It had been masked by the fact that we ~never invoke overlayDir with
an absolute path, which caused filepath.Rel to always return an error,
and overlayDir to always fall back to absolute paths.

Since the absolute paths seem to be working fine (and are simpler),
let's stick with those. As far as I can recall, the relative paths
were only a space optimization anyway.

Updates #28387
Updates #30316

Change-Id: Ie8cd28f3c41ca6497ace2799f4193d7f5dde7a37
Reviewed-on: https://go-review.googlesource.com/c/go/+/208481
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
misc/cgo/life/overlaydir_test.go
misc/cgo/stdio/overlaydir_test.go
misc/cgo/test/overlaydir_test.go
misc/cgo/testcarchive/overlaydir_test.go
misc/cgo/testcshared/overlaydir_test.go
misc/cgo/testplugin/overlaydir_test.go
misc/cgo/testshared/overlaydir_test.go
misc/cgo/testso/overlaydir_test.go
misc/cgo/testsovar/overlaydir_test.go
misc/reboot/overlaydir_test.go