]> Cypherpunks repositories - gostls13.git/commit
cmd/trace: remove unrelated arrows in task-oriented traceview
authorHana Kim <hakim@google.com>
Fri, 2 Mar 2018 20:52:30 +0000 (15:52 -0500)
committerHyang-Ah Hana Kim <hyangah@gmail.com>
Fri, 9 Mar 2018 01:34:12 +0000 (01:34 +0000)
commit476f71c9586c18235cdc678b2e8d7fadd7570d3d
tree08d9ba63ed0bcb8e4c3ecd572fb8b190790b1726
parent53c416396fafb9f73b24159134836bbbd2266d29
cmd/trace: remove unrelated arrows in task-oriented traceview

Also grey out instants that represent events occurred outside the
task's span. Furthermore, if the unrelated instants represent user
annotation events but not for the task of the interest, skip rendering
completely.

This helps users to focus on the task-related events better.

UI screen shot:
https://gist.github.com/hyangah/1df5d2c8f429fd933c481e9636b89b55#file-golang-org_cl_99035

Change-Id: I2b5aef41584c827f8c1e915d0d8e5c95fe2b4b65
Reviewed-on: https://go-review.googlesource.com/99035
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
src/cmd/trace/annotations.go
src/cmd/trace/trace.go