]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.15] cmd/link: recompute heapPos after copyHeap
authorCherry Zhang <cherryyz@google.com>
Wed, 18 Nov 2020 00:10:51 +0000 (19:10 -0500)
committerCarlos Amedee <carlos@golang.org>
Thu, 3 Dec 2020 14:06:12 +0000 (14:06 +0000)
commit480da601431545e3415e25515ac342c583935599
tree6d0c7094132222f814a82138768850f00eb85ab2
parenta2adbc876e9362f064afffcb51ce677e2f988c5e
[release-branch.go1.15] cmd/link: recompute heapPos after copyHeap

Immediately after a forward Seek, the offset we're writing to is
beyond len(buf)+len(heap):

|<--- buf --->|<--- heap --->|
                                    ^
                                    off

If we do a copyHeap at this point, the new heapPos should not be
0:

|<---------- buf ----------->|<-heap->|
                                    ^
                                    off

Recompute it.

Updates #42082
Fixes #42948

Change-Id: Icb3e4e1c7bf7d1fd3d76a2e0d7dfcb319c661534
Reviewed-on: https://go-review.googlesource.com/c/go/+/270942
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
Trust: Cherry Zhang <cherryyz@google.com>
src/cmd/link/internal/ld/outbuf.go