]> Cypherpunks repositories - gostls13.git/commit
runtime: simplify cpuprof hash calculation
authorMatthew Dempsky <mdempsky@google.com>
Thu, 18 Dec 2014 21:50:57 +0000 (13:50 -0800)
committerMinux Ma <minux@golang.org>
Fri, 19 Dec 2014 02:50:40 +0000 (02:50 +0000)
commit481ce36ec43dc699c6be18ec81dfce02ca24601c
tree02b55876815fe8830db39609f0b963278f750bb3
parent7a8e897979c7436f0baa0f7996542dc3c39023f4
runtime: simplify cpuprof hash calculation

"x*41" computes the same value as "x*31 + x*7 + x*3" and (when
compiled by gc) requires just one multiply instruction instead of
three.

Alternatively, the expression could be written as "(x<<2+x)<<3 + x" to
use shifts instead of multiplies (which is how GCC optimizes "x*41").
But gc currently emits suboptimal instructions for this expression
anyway (e.g., separate SHL+ADD instructions rather than LEA on
386/amd64). Also, if such an optimization was worthwhile, it would
seem better to implement it as part of gc's strength reduction logic.

Change-Id: I7156b793229d723bbc9a52aa9ed6111291335277
Reviewed-on: https://go-review.googlesource.com/1830
Reviewed-by: Minux Ma <minux@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/runtime/cpuprof.go