]> Cypherpunks repositories - gostls13.git/commit
encoding/xml: check type when unmarshaling innerxml field
authorQuentin Smith <quentin@golang.org>
Tue, 8 Nov 2016 21:47:04 +0000 (16:47 -0500)
committerQuentin Smith <quentin@golang.org>
Wed, 9 Nov 2016 20:10:58 +0000 (20:10 +0000)
commit48c6048e554ff4f428aefd41b9345ed5ec634783
tree7d96c9c85a53293aa929c09cf221373270f5d8d9
parent9c2037fbcf1a732f55e29062f3d30ddd21ca36d3
encoding/xml: check type when unmarshaling innerxml field

We only support unmarshaling into a string or a []byte, but we
previously would try (and panic while) setting a slice of a different
type. The docs say ",innerxml" is ignored if the type is not string or
[]byte, so do that for other slices as well.

Fixes #15600.

Change-Id: Ia64815945a14c3d04a0a45ccf413e38b58a69416
Reviewed-on: https://go-review.googlesource.com/32919
Run-TryBot: Quentin Smith <quentin@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
src/encoding/xml/read.go
src/encoding/xml/read_test.go