]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: fix mapassign_fast* routines for pointer keys
authorKeith Randall <keithr@alum.mit.edu>
Tue, 21 Nov 2017 15:14:11 +0000 (07:14 -0800)
committerKeith Randall <khr@golang.org>
Wed, 22 Nov 2017 04:30:27 +0000 (04:30 +0000)
commit48e207d518b2924fee598a8442230635d60649a9
treeb6bd487f34f75f9b20d5cd51694b1c016e26550c
parenta2a1c173d7917e86e2f0a3323676ae29f188593c
cmd/compile: fix mapassign_fast* routines for pointer keys

The signature of the mapassign_fast* routines need to distinguish
the pointerness of their key argument.  If the affected routines
suspend part way through, the object pointed to by the key might
get garbage collected because the key is typed as a uint{32,64}.

This is not a problem for mapaccess or mapdelete because the key
in those situations do not live beyond the call involved.  If the
object referenced by the key is garbage collected prematurely, the
code still works fine.  Even if that object is subsequently reallocated,
it can't be written to the map in time to affect the lookup/delete.

Fixes #22781

Change-Id: I0bbbc5e9883d5ce702faf4e655348be1191ee439
Reviewed-on: https://go-review.googlesource.com/79018
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Martin Möhrmann <moehrmann@google.com>
src/cmd/compile/internal/gc/builtin.go
src/cmd/compile/internal/gc/builtin/runtime.go
src/cmd/compile/internal/gc/walk.go
src/runtime/hashmap_fast.go
test/fixedbugs/issue22781.go [new file with mode: 0644]