]> Cypherpunks repositories - gostls13.git/commit
cmd/go: treat cached test results as satisfying any timeout
authorRuss Cox <rsc@golang.org>
Wed, 8 Nov 2017 16:54:34 +0000 (11:54 -0500)
committerRuss Cox <rsc@golang.org>
Thu, 9 Nov 2017 15:04:22 +0000 (15:04 +0000)
commit48f2a55aa1e8e13b220419142cadf1347daac5e8
tree15f25d02ba33b64dc21847bbc609b30a51c87607
parent5993251c015dfa1e905bdf44bdb41572387edf90
cmd/go: treat cached test results as satisfying any timeout

We want test caching to work even for people with scripts
that set a non-default test timeout. But then that raises the
question of what to do about runs with different timeouts:
is a cached success with one timeout available for use when
asked to run the test with a different timeout?

This CL answers that question by saying that the timeout applies
to the overall execution of either running the test or displaying
the cached result, and displaying a cached result takes no time.
So it's always OK to record a cached result, regardless of timeout,
and it's always OK to display a cached result, again regardless of timeout.

Fixes #22633.

Change-Id: Iaef3602710e3be107602267bbc6dba9a2250796c
Reviewed-on: https://go-review.googlesource.com/76552
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: roger peppe <rogpeppe@gmail.com>
Reviewed-by: David Crawshaw <crawshaw@golang.org>
src/cmd/go/go_test.go
src/cmd/go/internal/test/test.go