]> Cypherpunks repositories - gostls13.git/commit
asm: give error message for unadorned symbol reference
authorRob Pike <r@golang.org>
Thu, 17 Sep 2015 17:37:07 +0000 (10:37 -0700)
committerRob Pike <r@golang.org>
Fri, 18 Sep 2015 18:08:52 +0000 (18:08 +0000)
commit49580db149b177b0bbebb9fc61094b1e6c5a38d2
tree850ac8856ee314e95da3e5ab36de74026cddfd7b
parent8bd222f046e15353ea389ffe2f5f503fa14b188c
asm: give error message for unadorned symbol reference

On amd64, the program

TEXT    foo0(SB),7,$-8
    ADDQ R520, R1
    RET

used to trigger this error because R520 was being passed through to obj:

asm: doasm: notfound ft=23 tt=23 00000 (x.s:2) ADDQ 0, 0 23 23

Now it gets this one, as it is indeed a parse error:

x.s:2: illegal addressing mode for symbol R520

This couldn't be fixed until #12632 had been fixed for arm64.

Fixes #12470.

Change-Id: I19830c4ae9337887b93f85d9a239e2b89dbb2219
Reviewed-on: https://go-review.googlesource.com/14691
Reviewed-by: Aram Hăvărneanu <aram@mgk.ro>
src/cmd/asm/internal/asm/parse.go