]> Cypherpunks repositories - gostls13.git/commit
all: simplify multiple for loops
authorDaniel Martí <mvdan@mvdan.cc>
Tue, 5 Mar 2019 20:44:29 +0000 (20:44 +0000)
committerDaniel Martí <mvdan@mvdan.cc>
Fri, 8 Mar 2019 14:29:19 +0000 (14:29 +0000)
commit49662bc6b02810389c66b6b24576f6a5b217d471
tree15769762bf84bad2b9f1a4a1181845a5ad0673f5
parentce7534ff06df5b3148aa325deedcb94ac5b30ec0
all: simplify multiple for loops

If a for loop has a simple condition and begins with a simple
"if x { break; }"; we can simply add "!x" to the loop's condition.

While at it, simplify a few assignments to use the common pattern
"x := staticDefault; if cond { x = otherValue(); }".

Finally, simplify a couple of var declarations.

Change-Id: I413982c6abd32905adc85a9a666cb3819139c19f
Reviewed-on: https://go-review.googlesource.com/c/go/+/165342
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
13 files changed:
src/cmd/compile/internal/gc/pgen.go
src/cmd/compile/internal/gc/reflect.go
src/cmd/compile/internal/gc/walk.go
src/cmd/compile/internal/ssa/schedule.go
src/cmd/internal/obj/pass.go
src/cmd/link/internal/ld/elf.go
src/encoding/json/encode.go
src/encoding/json/stream_test.go
src/internal/reflectlite/type.go
src/reflect/type.go
src/runtime/traceback.go
src/runtime/type.go
src/text/template/funcs.go