]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: skip ssa/debug_test.go when gdb missing etc.
authorDavid Chase <drchase@google.com>
Mon, 9 Oct 2017 20:41:25 +0000 (16:41 -0400)
committerDavid Chase <drchase@google.com>
Mon, 9 Oct 2017 21:08:19 +0000 (21:08 +0000)
commit4a2376ef027b0767bb6e0161ef8cfd13f3bc61bb
tree9a769dcc3abf10a8fe0cd61118b7572c329f088d
parent6f5ede8bd5faf92053be30eca9999fa16833b2b9
cmd/compile: skip ssa/debug_test.go when gdb missing etc.

CL50610 broke the build for noopt (different inlining
behavior) and clang (no gdb) so it needs to catch those
cases and skip.

The run/no-run logic was slightly cleaned up,
the name of gdb on OSX was made more robust (tries gdb
first, then ggdb), and the file names were canonicalized
before loggging instead of in comparison to reduce
gratuitous noise in diffs when things aren't otherwise
equal.

This probably doesn't fix problems on Alpine, but it should
provide a cleaner and less confusing failure.

Change-Id: I26c65bff5a8d3d60f1cd6ae02a282558c53dda67
Reviewed-on: https://go-review.googlesource.com/69371
Run-TryBot: David Chase <drchase@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/ssa/debug_test.go
src/cmd/compile/internal/ssa/testdata/hist-dbg.delve-nexts
src/cmd/compile/internal/ssa/testdata/hist-dbg.gdb-nexts
src/cmd/compile/internal/ssa/testdata/hist-opt.delve-nexts
src/cmd/compile/internal/ssa/testdata/hist-opt.gdb-nexts
src/cmd/compile/internal/ssa/testdata/hist.go