]> Cypherpunks repositories - gostls13.git/commit
net/http/httputil: allow MIME parameters when detecting SSE in ReverseProxy
authorJames Harris <mailjamesharris@gmail.com>
Fri, 17 Sep 2021 02:29:00 +0000 (02:29 +0000)
committerDamien Neil <dneil@google.com>
Wed, 13 Oct 2021 17:16:12 +0000 (17:16 +0000)
commit4a3daeee636751a262eb9f77d8e90c59955ee6bb
tree0b3b7026676a7f7020fd18cf053b4da251a985d8
parentb5904f3de0937aac72acd40d6c26494ebb9d7909
net/http/httputil: allow MIME parameters when detecting SSE in ReverseProxy

This change allows httputil.ReverseProxy to detect SSE (server-sent events)
content when the response's Content-Type header includes MIME parameters,
such as "text/event-stream;charset=utf-8".

Prior to this change the value of the Content-Type header was compared
directly to the literal "text/event-stream". This caused a false-negative
which failed to set the FlushInterval correctly when MIME parameters were
present.

Change-Id: If8bb43efb78787b6519d7fe7599ca018a0da0023
GitHub-Last-Rev: 224518c5eb9686ee050c79f5f853ebacfdf6fc42
GitHub-Pull-Request: golang/go#48427
Reviewed-on: https://go-review.googlesource.com/c/go/+/350509
Trust: Alexander Rakoczy <alex@golang.org>
Trust: Damien Neil <dneil@google.com>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
src/net/http/httputil/reverseproxy.go
src/net/http/httputil/reverseproxy_test.go