]> Cypherpunks repositories - gostls13.git/commit
net: use DialTimeout in TestSelfConnect
authorIan Lance Taylor <iant@golang.org>
Fri, 27 Dec 2013 16:49:47 +0000 (08:49 -0800)
committerIan Lance Taylor <iant@golang.org>
Fri, 27 Dec 2013 16:49:47 +0000 (08:49 -0800)
commit4aa521a77d1fdc36d68f9ad2591bb28addb327e5
treec7decf9a12db6baa1b37f48c3837786381f6bd71
parentd1a9143669633cd2f47f00b074d6534fc77e1e4d
net: use DialTimeout in TestSelfConnect

This avoids problems with systems that take a long time to
find out nothing is listening, while still testing for the
self-connect misfeature since a self-connect should be fast.
With this we may be able to remove the test for non-Linux
systems.

Tested (on GNU/Linux) by editing selfConnect in
tcpsock_posix.go to always return false and verifying that
TestSelfConnect then fails with and without this change.

Idea from Uros Bizjak.

R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/39200044
src/pkg/net/dial_test.go