]> Cypherpunks repositories - gostls13.git/commit
net/http: detect Comcast et al DNS and auto-skip DNS tests
authorKale Blankenship <kale@lemnisys.com>
Sun, 18 Dec 2016 04:40:29 +0000 (20:40 -0800)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 1 Feb 2017 23:54:44 +0000 (23:54 +0000)
commit4aa7b142681dba2a1d76e59ecb5dc6923a192eb0
tree89bf84e9c0bbb3f407bc630c030982a302fbd85f
parenta27b78141b85d3b9733647de3f3863977d2f9f81
net/http: detect Comcast et al DNS and auto-skip DNS tests

Adds helper function to auto-skip tests when DNS returns
a successful response for a domain known not to exist.

The error from `net.LookupHost` is intentionally ignored
because the DNS tests will fail anyway if there are issues
unrelated to NXDOMAIN responses.

Fixes #17884

Change-Id: I729391bd702218507561818668f791331295299e
Reviewed-on: https://go-review.googlesource.com/34516
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/net/http/transport_test.go