]> Cypherpunks repositories - gostls13.git/commit
go/types, types2: remove references to core type in append
authorRobert Griesemer <gri@golang.org>
Wed, 26 Feb 2025 17:57:31 +0000 (09:57 -0800)
committerGopher Robot <gobot@golang.org>
Mon, 3 Mar 2025 19:07:14 +0000 (11:07 -0800)
commit4b1ac7bbfe3e8e4872b1a4651c527ea8be4a045f
treef343deac2aa9e4f556215e1020cda9bff638b122
parentf48b53f0f62c94fac8d835c8e1b48fab5b842bd3
go/types, types2: remove references to core type in append

Writing explicit code for this case turned out to be simpler
and easier to reason about then relying on a helper functions
(except for typeset).

While at it, make append error messages more consistent.

For #70128.

Change-Id: I3dc79774249929de5061b4301ab2506d4b3da0d0
Reviewed-on: https://go-review.googlesource.com/c/go/+/653095
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
src/cmd/compile/internal/types2/builtins.go
src/go/types/builtins.go
src/internal/types/testdata/fixedbugs/issue49735.go