]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.22] cmd/internal/cov: close counter data files eagerly
authorThan McIntosh <thanm@google.com>
Tue, 16 Jul 2024 19:13:47 +0000 (19:13 +0000)
committerCherry Mui <cherryyz@google.com>
Wed, 17 Jul 2024 22:41:09 +0000 (22:41 +0000)
commit4c50f9162cafaccc1ab1bc26b0dea18f124b536d
tree77471a34701f97a6c4012b4977a796ccc402f05d
parent9e148a4150ece0c24e60197893c8821b2c67e151
[release-branch.go1.22] cmd/internal/cov: close counter data files eagerly

When reading the counter data files from a given pod, close the
underlying *os.File immediately after each one is read, as opposed to
using a deferred close in the loop (which will close them all at the
end of the function). Doing things this way avoids running into "too
many open files" when processing large clumps of counter data files.

Fixes #68492.
Updates #68468.

Change-Id: Ic1fe1d36c44d3f5d7318578cd18d0e65465d71d9
Reviewed-on: https://go-review.googlesource.com/c/go/+/598735
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit 355711821eea51c6456a31ab61d0dc2e9db034f7)
Reviewed-on: https://go-review.googlesource.com/c/go/+/599036
src/cmd/internal/cov/readcovdata.go