]> Cypherpunks repositories - gostls13.git/commit
crypto/tls: prevent the test server from sending session tickets
authorFilippo Valsorda <hi@filippo.io>
Thu, 29 Nov 2018 03:05:08 +0000 (22:05 -0500)
committerFilippo Valsorda <filippo@golang.org>
Thu, 29 Nov 2018 05:55:51 +0000 (05:55 +0000)
commit4c51c937808ee2fb88d469cf89c85c8e700f665c
treecaf370ae7add4eb2c1a549d5fef4836e78a66828
parent4f26f24d2ae8c99bfaafb33db4b7be27ee13afab
crypto/tls: prevent the test server from sending session tickets

Since they are sent after the handshake in TLS 1.3, the client was not
actually consuming them, as it doesn't make any Read calls. They were
then sitting in the kernel receive buffer when the client would call
Close. The kernel would see that and send a RST, which would race the
closeNotify, causing errors.

Also, we get to trim 600 lines of useless test data.

Fixes #28852

Change-Id: I7517feab77dabab7504bfc111098ba09ea07ae5e
Reviewed-on: https://go-review.googlesource.com/c/151659
Reviewed-by: Ian Lance Taylor <iant@golang.org>
14 files changed:
src/crypto/tls/handshake_client_test.go
src/crypto/tls/testdata/Client-TLSv13-AES128-SHA256
src/crypto/tls/testdata/Client-TLSv13-AES256-SHA384
src/crypto/tls/testdata/Client-TLSv13-ALPN
src/crypto/tls/testdata/Client-TLSv13-CHACHA20-SHA256
src/crypto/tls/testdata/Client-TLSv13-ClientCert-ECDSA-RSA
src/crypto/tls/testdata/Client-TLSv13-ClientCert-RSA-ECDSA
src/crypto/tls/testdata/Client-TLSv13-ClientCert-RSA-RSAPSS
src/crypto/tls/testdata/Client-TLSv13-ECDSA
src/crypto/tls/testdata/Client-TLSv13-ExportKeyingMaterial
src/crypto/tls/testdata/Client-TLSv13-HelloRetryRequest
src/crypto/tls/testdata/Client-TLSv13-KeyUpdate
src/crypto/tls/testdata/Client-TLSv13-P256-ECDHE
src/crypto/tls/testdata/Client-TLSv13-X25519-ECDHE