]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.13] crypto/ecdsa: remove s390x assembly
authorMichael Munday <mike.munday@ibm.com>
Wed, 16 Oct 2019 21:38:40 +0000 (22:38 +0100)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 16 Oct 2019 22:09:14 +0000 (22:09 +0000)
commit4cb22ee8120ddd9cd8a9ef88ae2a142c5d2f8432
treea835179cd48ba0c94cd1a5c78cdd15bca068e308
parent985804b4276e5da21f10a326ab9f5a5383b4377b
[release-branch.go1.13] crypto/ecdsa: remove s390x assembly

This is a revert of CL 174437 and equivalent to CL 201360.

The size of the params block passed into the KDSA instruction is
incorrect and this appears to result in out-of-bounds writes
that cause a panic in the crypto/x509 tests when run on a machine
that supports KDSA.

Remove this assembly for now. We can revisit the use of the KDSA
instruction in a future release.

Fixes #34928.

Change-Id: I7ad2fe9714b47ad04abc25f18aa235b9d2aef062
Reviewed-on: https://go-review.googlesource.com/c/go/+/201361
Run-TryBot: Michael Munday <mike.munday@ibm.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/crypto/ecdsa/ecdsa.go
src/crypto/ecdsa/ecdsa_noasm.go [deleted file]
src/crypto/ecdsa/ecdsa_s390x.go [deleted file]
src/crypto/ecdsa/ecdsa_s390x.s [deleted file]
src/crypto/ecdsa/ecdsa_s390x_test.go [deleted file]