]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.16] cmd/compile: remove incorrect arm,arm64 CMP->CMN transformations
authorDavid Chase <drchase@google.com>
Thu, 27 Jan 2022 16:26:59 +0000 (11:26 -0500)
committerCherry Mui <cherryyz@google.com>
Mon, 7 Feb 2022 18:41:46 +0000 (18:41 +0000)
commit4d284ea05230c37a653053c163f0eb8b1f9b6138
tree1cceb89c055ca5219a245f0c16e266916b773e91
parentfcd482a2d014137d8c20bf02bcc8fe37b107eb8c
[release-branch.go1.16] cmd/compile: remove incorrect arm,arm64 CMP->CMN transformations

These can go wrong when one of the operands is the minimum integer value.

Fixes #50866.

Change-Id: I238fe284f60c7ee5aeb9dc9a18e8b1578cdb77d0
Reviewed-on: https://go-review.googlesource.com/c/go/+/381318
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Trust: David Chase <drchase@google.com>
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit b7b44b3173f151a2313da7072afd25de80511605)
Reviewed-on: https://go-review.googlesource.com/c/go/+/381475
Trust: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
src/cmd/compile/internal/ssa/gen/ARM.rules
src/cmd/compile/internal/ssa/gen/ARM64.rules
src/cmd/compile/internal/ssa/gen/ARM64Ops.go
src/cmd/compile/internal/ssa/gen/ARMOps.go
src/cmd/compile/internal/ssa/rewriteARM.go
src/cmd/compile/internal/ssa/rewriteARM64.go
test/fixedbugs/issue50854.go [new file with mode: 0644]