]> Cypherpunks repositories - gostls13.git/commit
runtime: move timer recheck after GC recheck
authorMichael Pratt <mpratt@google.com>
Thu, 8 Apr 2021 20:57:57 +0000 (16:57 -0400)
committerMichael Pratt <mpratt@google.com>
Wed, 21 Apr 2021 13:38:59 +0000 (13:38 +0000)
commit4d56576ec02e3e3b4459bc23eb1601e6e96f3cfc
tree14a21c857ae29690774e4073713c180ad2d9a28d
parent381252f312a513a969d9aa1d84cec2c9c1becf4d
runtime: move timer recheck after GC recheck

When rechecking for work after transitioning from a spinning to
non-spinning M, checking timers before GC isn't useful. That is, if
there is GC work available, it will run immediately and the updated
pollUntil is unused.

Move this check to just before netpoll, where pollUntil is used. While
this technically improves efficiency in the (rare) case that we find
GC work in this block, the primary motivation is simply to improve
clarity by moving the update closer to use.

For #43997

Change-Id: Ibc7fb308ac4a582875c200659c9e272121a89f3b
Reviewed-on: https://go-review.googlesource.com/c/go/+/308654
Trust: Michael Pratt <mpratt@google.com>
Trust: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
src/runtime/proc.go