]> Cypherpunks repositories - gostls13.git/commit
path/filepath: document and test behavior of SkipDir on files
authorRuss Cox <rsc@golang.org>
Mon, 29 Jun 2015 15:53:51 +0000 (11:53 -0400)
committerRuss Cox <rsc@golang.org>
Mon, 29 Jun 2015 21:16:35 +0000 (21:16 +0000)
commit4df6b1ec2f27d0dded28ecc7cde5d12f57e144d9
treed06697f49b4d9f00564ba36820a1eae269186ca1
parent69f0d4c6bebc775cfbc50e9562b5533ba86b90c9
path/filepath: document and test behavior of SkipDir on files

This behavior is not what we might have designed from the start,
but it has been present since Go 1. Rather than make a visible
behavioral change that might cause programs to work differently
in Go ≤1.4 vs Go ≥1.5, document what SkipDir on a non-directory
has always meant. If code doesn't want this meaning, it is easy
enough not to return SkipDir on non-directories.

Fixes #10533.

Change-Id: Ic0612f032044bc7c69bf62583a02037e4b47530b
Reviewed-on: https://go-review.googlesource.com/11690
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
src/path/filepath/path.go
src/path/filepath/path_test.go