]> Cypherpunks repositories - gostls13.git/commit
net/http: fix ProxyFromEnvironment panic on invalid $NO_PROXY value
authorJakob Borg <jakob@nym.se>
Mon, 13 Mar 2017 23:21:51 +0000 (08:21 +0900)
committerBrad Fitzpatrick <bradfitz@golang.org>
Tue, 21 Mar 2017 01:16:37 +0000 (01:16 +0000)
commit4e35e5fcabb504a14b9533692c9ae1a8c38b1139
treef8189dd9109b5ab355402a9957554c6a1bf13b2d
parentdf68afd07ce67727bcc2ad8e4afaa42dbcbf58e7
net/http: fix ProxyFromEnvironment panic on invalid $NO_PROXY value

Given an entry in $no_proxy like ":1" we would interpret it as an empty
host name and a port number, then check the first character of the host
name for dots. This would then cause an index out of range panic. This
change simply skips these entries, as the following checks would anyway
have returned false.

Fixes #19536

Change-Id: Iafe9c7a77ad4a6278c8ccb00a1575b56e4bdcd79
Reviewed-on: https://go-review.googlesource.com/38067
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/net/http/proxy_test.go
src/net/http/transport.go