]> Cypherpunks repositories - gostls13.git/commit
cmd/go: clean up compile vs link vs shared library actions
authorRuss Cox <rsc@golang.org>
Tue, 10 Oct 2017 01:07:32 +0000 (21:07 -0400)
committerRuss Cox <rsc@golang.org>
Wed, 11 Oct 2017 17:47:09 +0000 (17:47 +0000)
commit4e8be99590d54cc9ea949d9eadc560a1c2456539
tree76c91e0fe8f388c1688315d3c1b63aa435b8d69e
parent2595fe7fb6f272f9204ca3ef0b0c55e66fb8d90f
cmd/go: clean up compile vs link vs shared library actions

Everything got a bit tangled together in b.action1.
Try to tease things apart again.

In general this is a refactoring of the existing code, with limited
changes to the effect of the code.

The main additional change is to complete a.Deps for link actions.
That list now directly contains all the inputs the linker will attempt
to read, eliminating the need for a transitive traversal of the entire
action graph to find those. The comepleteness of a.Deps will be
important when we eventually use it to decide whether an cached
action output can be reused.

all.bash passes, but it's possible I've broken some subtety of
buildmode=shared again. Certainly that code took the longest
to get working.

Change-Id: I34e849eda446dca45a9cfce02b07bec6edb6d0d4
Reviewed-on: https://go-review.googlesource.com/69831
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Crawshaw <crawshaw@golang.org>
misc/cgo/testcarchive/carchive_test.go
misc/cgo/testshared/shared_test.go
src/cmd/go/internal/load/pkg.go
src/cmd/go/internal/run/run.go
src/cmd/go/internal/test/test.go
src/cmd/go/internal/work/build.go