]> Cypherpunks repositories - gostls13.git/commit
cmd/compile, runtime: use R20, R21 in ARM64's Duff's devices
authorCherry Zhang <cherryyz@google.com>
Tue, 25 Jun 2019 18:48:04 +0000 (14:48 -0400)
committerCherry Zhang <cherryyz@google.com>
Wed, 26 Jun 2019 16:01:47 +0000 (16:01 +0000)
commit4ea7aa7cf3755533634904d934c89f93d461d642
treec2bbd74b1f9f4d4e5b131b0afb881039b5818722
parent24f7d89a73b7bd77127a56e8a8552c48278d251b
cmd/compile, runtime: use R20, R21 in ARM64's Duff's devices

Currently we use R16 and R17 for ARM64's Duff's devices.
According to ARM64 ABI, R16 and R17 can be used by the (external)
linker as scratch registers in trampolines. So don't use these
registers to pass information across functions.

It seems unlikely that calling Duff's devices would need a
trampoline in normal cases. But it could happen if the call
target is out of the 128 MB direct jump limit.

The choice of R20 and R21 is kind of arbitrary. The register
allocator allocates from low-numbered registers. High numbered
registers are chosen so it is unlikely to hold a live value and
forces a spill.

Fixes #32773.

Change-Id: Id22d555b5afeadd4efcf62797d1580d641c39218
Reviewed-on: https://go-review.googlesource.com/c/go/+/183842
Run-TryBot: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/arm64/ggen.go
src/cmd/compile/internal/arm64/ssa.go
src/cmd/compile/internal/ssa/gen/ARM64Ops.go
src/cmd/compile/internal/ssa/opGen.go
src/cmd/internal/obj/arm64/a.out.go
src/runtime/duff_arm64.s
src/runtime/mkduff.go