]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: allow spaces in types.(*Type).LinkString()
authorDan Scales <danscales@google.com>
Tue, 12 Oct 2021 19:52:59 +0000 (12:52 -0700)
committerDan Scales <danscales@google.com>
Wed, 13 Oct 2021 00:11:47 +0000 (00:11 +0000)
commit4fb2e1cb86a1f15a69ebf97a80503e865287642c
tree8d76f5950c44b47dda3a99ed769927850067126f
parent78d01be00b68d1f5c3f5eb493f053ba97adc92df
cmd/compile: allow spaces in types.(*Type).LinkString()

Go back to allowing spaces in types.(*Type).LinkSring().

Delve folks prefer that there are spaces in type names, if needed, since
DWARF expects type names to be "a string representing the name as it
appears in the source program". At this point, it doesn't necessarily
seem worth having a separate function that removes spaces, only for use
when printing the type names in a function/method instantiation.

Most names of function/method instantiations will still not have spaces,
since they most type args are named or builtin types. I confirmed that
we are back to the original definition of LinkString(), except for some
comment changes.

Change-Id: Iab7143f659ddea4f099c6230cb134edf8aaef868
Reviewed-on: https://go-review.googlesource.com/c/go/+/355354
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dan Scales <danscales@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/types/fmt.go