]> Cypherpunks repositories - gostls13.git/commit
cmd/go: make sure linker -o for plugin doesn't include tempdir path
authorMichael Matloob <matloob@golang.org>
Fri, 17 Mar 2023 15:40:25 +0000 (11:40 -0400)
committerMichael Matloob <matloob@golang.org>
Fri, 17 Mar 2023 20:16:14 +0000 (20:16 +0000)
commit50479b79bcd5920bcbca9698f6a382660bb53179
treeb6fe472c3a95278fad06306aab7591001638e1a9
parent553506d39a44a4f56f4f801b15e82fea7f542403
cmd/go: make sure linker -o for plugin doesn't include tempdir path

There is already a case that when buildmode=shared passes only the
basename of the -o argument to the link command to the linker (and
runs in the directory of that argument) to avoid having that
(temporary) directory of the file be included in the LC_ID_DYLIB load
command. Extend the case to buildmode=plugin, because the same thing
can happen there.

This can only happen on darwin: the -o command can be embedded into
Mach-O and PE binaries, but plugin isn't supported on Windows.

For #58557

Change-Id: I7a4a5627148e77c6906ac4583af3d9f053d5b249
Reviewed-on: https://go-review.googlesource.com/c/go/+/477296
Run-TryBot: Michael Matloob <matloob@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
src/cmd/go/internal/work/gc.go
src/cmd/go/testdata/script/build_plugin_reproducible.txt [new file with mode: 0644]