]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: bail PGO method lookup on interface types
authorMichael Pratt <mpratt@google.com>
Wed, 24 Apr 2024 15:19:17 +0000 (11:19 -0400)
committerMichael Pratt <mpratt@google.com>
Wed, 24 Apr 2024 15:55:11 +0000 (15:55 +0000)
commit508e76197842792f87504d9f031ce4f7bf453c4f
tree95f3c105e97220bf8686312ab597d3485f912306
parent3aad2d0765b9f652e1964a8261d6ef0035d9535f
cmd/compile: bail PGO method lookup on interface types

Interface types don't have concrete method implementations, so it does
not make sense to attempt a lookup.

An interface method would not normally appear in a PGO profile as it has
no symbol in the final binary. However it can appear if the method was
concrete when the profile was collected and it has since been refactored
to an interface method in the code being compiled.

The guards here (OTYPE, !Alias, !IsInterface) now match
noder.linker.relocObj, which does a similar iteration of all methods.

Fixes #67016.

Change-Id: I858c58929c890ac0b2019fbd7c99f683ab63f8bb
Reviewed-on: https://go-review.googlesource.com/c/go/+/581436
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/cmd/compile/internal/noder/unified.go