]> Cypherpunks repositories - gostls13.git/commit
runtime: switch gp when jumping stacks during traceback
authorAustin Clements <austin@google.com>
Tue, 12 Jul 2022 20:35:26 +0000 (16:35 -0400)
committerGopher Robot <gobot@golang.org>
Fri, 2 Sep 2022 19:08:50 +0000 (19:08 +0000)
commit511cd9b8af10de9cad86be38a22e5eb2e5d4cd8d
tree961a1214fd0a62de3e505e4b10c0c1a0956e34dd
parentf00fa0b98da9f4353839da99e6f6f7f109f9954f
runtime: switch gp when jumping stacks during traceback

Currently, when traceback jumps from the system stack to a user stack
(e.g., during profiling tracebacks), it leaves gp pointing at the g0.
This is currently harmless since it's only used during profiling, so
the code paths in gentraceback that care about gp aren't used, but
it's really confusing and would certainly break if _TraceJumpStack
were ever used in a context other than profiling.

Fix this by updating gp to point to the user g when we switch stacks.

For #54466.

Change-Id: I1541e004667a52e37671803ce45c91d8c5308830
Reviewed-on: https://go-review.googlesource.com/c/go/+/424257
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Austin Clements <austin@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Austin Clements <austin@google.com>
src/runtime/traceback.go