]> Cypherpunks repositories - gostls13.git/commit
go/types: improve error message for pointer receiver errors
authorRebecca Stambler <rstambler@golang.org>
Fri, 24 Apr 2020 05:01:48 +0000 (01:01 -0400)
committerRebecca Stambler <rstambler@golang.org>
Fri, 24 Apr 2020 18:49:16 +0000 (18:49 +0000)
commit512277dc19b918da19e083c28427109256ef9309
tree44cfc1d3d5dc3921634fc50cef5dc125ced42217
parentda33f9c78a89c0997269a77e134127c135583963
go/types: improve error message for pointer receiver errors

The compiler produces high quality error messages when an interface is
implemented by *T, rather than T. This change improves the analogous
error messages in go/types, from "missing method X" to "missing method
X (X has pointer receiver)".

I am open to improving this message further - I didn't copy the compiler
error message exactly because, at one of the call sites of
(*check).missingMethod, we no longer have access to the name of the
interface.

Fixes golang/go#36336

Change-Id: Ic4fc38b13fff9e5d9a69cc750c21e0b0c34d85a8
Reviewed-on: https://go-review.googlesource.com/c/go/+/229801
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
src/go/types/expr.go
src/go/types/lookup.go
src/go/types/operand.go
src/go/types/testdata/issues.src