]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.23] cmd/trace: also show end stack traces
authorFelix Geisendörfer <felix.geisendoerfer@datadoghq.com>
Tue, 26 Nov 2024 08:10:22 +0000 (09:10 +0100)
committerGopher Robot <gobot@golang.org>
Wed, 27 Nov 2024 20:24:20 +0000 (20:24 +0000)
commit5164a865e3de723f07976edac234c4d6a814128e
treed7489b2a3d09469c3257cdd41d1563fe4360a2e9
parent25f042daecda1058baa25b213f1692d22ff5fb73
[release-branch.go1.23] cmd/trace: also show end stack traces

Fix a regression that appeared in 1.23 when it comes to the stack traces
shown in the trace viewer. In 1.22 and earlier, the viewer was always
showing end stack traces. In 1.23 and later the viewer started to
exclusively show start stack traces.

Showing only the start stack traces made it impossible to see the last
stack trace produced by a goroutine. It also made it hard to understand
why a goroutine went off-cpu, as one had to hunt down the next running
slice of the same goroutine.

Emit end stack traces in addition to start stack traces to fix the
issue.

Fixes #70592

Change-Id: Ib22ea61388c1d94cdbc99fae2d207c4dce011a59
Reviewed-on: https://go-review.googlesource.com/c/go/+/631895
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Felix Geisendörfer <felix.geisendoerfer@datadoghq.com>
Reviewed-by: Nick Ripley <nick.ripley@datadoghq.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
(cherry picked from commit 6405e60ca6be798c1f8c1d0365fd63b89b524df5)
Reviewed-on: https://go-review.googlesource.com/c/go/+/632075
Reviewed-by: Veronica Silina <veronicasilina@google.com>
Auto-Submit: Veronica Silina <veronicasilina@google.com>
src/cmd/trace/gstate.go