]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.20] internal/coverage/decodemeta: fix coding error in func litera...
authorThan McIntosh <thanm@google.com>
Fri, 20 Jan 2023 19:03:43 +0000 (14:03 -0500)
committerMatthew Dempsky <mdempsky@google.com>
Thu, 26 Jan 2023 23:27:53 +0000 (23:27 +0000)
commit52bd3b186bd18a1104bd74780fbcb20d35a1114d
treeb14d37774d6cad70be3835646c54a8e6ee13d42e
parentbe7e4fee4b6a96074d003d7211047c23ae9e6c18
[release-branch.go1.20] internal/coverage/decodemeta: fix coding error in func literal handling

Fix a coding error in coverage meta-data decoding in the method
decodemeta.CoverageMetaDataDecoder.ReadFunc. The code was not
unconditionally assigning the "function literal" field of the
coverage.FuncDesc object passed in, resulting in bad values depending
on what the state of the field happened to be in the object.

Fixes #57942.

Change-Id: I6dfd7d7f7af6004f05c622f9a7116e9f6018cf4f
Reviewed-on: https://go-review.googlesource.com/c/go/+/462955
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
(cherry picked from commit 620399ef0d1390a8f7e7061a45d5304ed087889a)
Reviewed-on: https://go-review.googlesource.com/c/go/+/463418
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
src/cmd/covdata/dump.go
src/internal/coverage/decodemeta/decode.go
src/internal/coverage/test/roundtrip_test.go