]> Cypherpunks repositories - gostls13.git/commit
cmd/internal/obj, cmd/link: fix st_other field on PPC64
authorIan Lance Taylor <iant@golang.org>
Tue, 9 May 2017 21:34:16 +0000 (14:34 -0700)
committerIan Lance Taylor <iant@golang.org>
Tue, 9 May 2017 23:36:51 +0000 (23:36 +0000)
commit5331e7e9df017374a05a66497fd367e165b8aaf5
tree4db5424e6ccafca41f1e200ac8289e594f40564e
parent08dca4c649ba7f90f209376ba342bd46ef14ebe5
cmd/internal/obj, cmd/link: fix st_other field on PPC64

In PPC64 ELF files, the st_other field indicates the number of
prologue instructions between the global and local entry points.
We add the instructions in the compiler and assembler if -shared is used.
We were assuming that the instructions were present when building a
c-archive or PIE or doing dynamic linking, on the assumption that those
are the cases where the go tool would be building with -shared.
That assumption fails when using some other tool, such as Bazel,
that does not necessarily use -shared in exactly the same way.

This CL records in the object file whether a symbol was compiled
with -shared (this will be the same for all symbols in a given compilation)
and uses that information when setting the st_other field.

Fixes #20290.

Change-Id: Ib2b77e16aef38824871102e3c244fcf04a86c6ea
Reviewed-on: https://go-review.googlesource.com/43051
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Michael Hudson-Doyle <michael.hudson@canonical.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
misc/cgo/testcarchive/carchive_test.go
src/cmd/internal/goobj/read.go
src/cmd/internal/obj/objfile.go
src/cmd/internal/obj/ppc64/obj9.go
src/cmd/internal/objabi/doc.go
src/cmd/link/internal/ld/link.go
src/cmd/link/internal/ld/objfile.go
src/cmd/link/internal/ld/symtab.go