]> Cypherpunks repositories - gostls13.git/commit
cmd/compile/internal/walk: remove reduceSlice
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Thu, 22 Sep 2022 11:53:12 +0000 (18:53 +0700)
committerGopher Robot <gobot@golang.org>
Thu, 22 Sep 2022 21:36:44 +0000 (21:36 +0000)
commit533cd80315904661e3d644a140bdf52c8ac7aad6
tree60e021f8cb0a45023bbf92d06641c282226cdbab
parent42a46206b97ca7cf4246d3c1230a70cf42ad5bb0
cmd/compile/internal/walk: remove reduceSlice

After CL 22425, there're two optimizations for slice expr which are
never applied during walk pass:

s[i:len(s)]
        s[i:j:cap(s)]

The order pass have already rewritten len/cap expression to use autotmp,
thus the same safe expression check will never fire. The code can now be
simplified by moving the only case left from reduceSlice to walkSlice,
then removing reduceSlice entirely.

Passes toolstash-check.

Change-Id: Ia8cfb15c8e96c186a214c17b42d0fee51b0d3a1c
Reviewed-on: https://go-review.googlesource.com/c/go/+/432695
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/cmd/compile/internal/walk/expr.go