]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.21] cmd/cgo/internal/swig: force use of lld for LTO tests on...
authorMichael Anthony Knyszek <mknyszek@google.com>
Thu, 30 May 2024 03:36:41 +0000 (03:36 +0000)
committerJoedian Reid <joedian@google.com>
Mon, 24 Jun 2024 17:05:40 +0000 (17:05 +0000)
commit537ec6f21ec4b69142b9c5c9f8bcb2c66cf68274
tree173d2c18cf5c3ad9f4b34861cf333150a4375266
parentdfb006701893e0ac9fc12ab2bbd65e1d61c517c8
[release-branch.go1.21] cmd/cgo/internal/swig: force use of lld for LTO tests on the builders

For whatever reason, on the builders, when using /usr/bin/ld (the
default linker) with -flto we end up with problems. Specifically, the
linker seems to require LLVMgold.so and can't find it. I'm not really
sure why, but what definitely seems to work is forcing use of lld, which
ships with our clang installation on the builders.

Just enforce this on the builders for now; I've actually had very few
problems running this locally (and I think I'm also mixing and matching
linkers and toolchains too...), so it may be related to the version of
clang we're testing with.

For #67698.
For #67714.

Change-Id: I3bfbcd609e7d0fd70e52ac7e2a0817db95664f20
Cq-Include-Trybots: luci.golang.try:go1.21-linux-amd64-clang15,go1.21-linux-386-clang15
Reviewed-on: https://go-review.googlesource.com/c/go/+/589296
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/591377
src/cmd/cgo/internal/swig/swig_test.go