]> Cypherpunks repositories - gostls13.git/commit
syscall: correct code for cover cmd
authorDmitry Vyukov <dvyukov@google.com>
Fri, 10 Apr 2015 09:34:31 +0000 (12:34 +0300)
committerDmitry Vyukov <dvyukov@google.com>
Fri, 10 Apr 2015 16:59:06 +0000 (16:59 +0000)
commit53a8ee5011c2cca9f938af2ff2973ed8897aa597
tree94e67b2d89e0184aec8f8695f02abf8def5875f9
parent7647741246691a17f17799ae1f4c54a9828b90e4
syscall: correct code for cover cmd

Fixes #10378

This is clumsy, but currently cover tool fails as:

$ go test -run=none -cover syscall
syscall_linux_amd64.go:15: can only use //go:noescape with external func implementations
FAIL syscall [build failed]

This happens because cover tool mishandles //go: comments.
r and gri said that fixing cover is infeasible due to go/ast limitations.

So at least fix the offending code so that coverage works.
This come up in context of coverage-guided fuzzing which works best
with program-wide coverage.

Change-Id: I142e5774c9f326ed38cb202693bd4edae93879ba
Reviewed-on: https://go-review.googlesource.com/8723
Reviewed-by: Rob Pike <r@golang.org>
src/syscall/syscall_linux_amd64.go