]> Cypherpunks repositories - gostls13.git/commit
net/http/httptest: make Server.CloseClientConnections wait for conns to close
authorBrad Fitzpatrick <bradfitz@golang.org>
Wed, 10 Feb 2016 19:58:44 +0000 (19:58 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 10 Feb 2016 21:30:13 +0000 (21:30 +0000)
commit53b66616736480152969fe1749f62e3da07644f7
treead343e98589dfbfd58c8573368d2a89fe04fd172
parent7ebf653fcc8510f260a1afbc3fb9e3de157dfe04
net/http/httptest: make Server.CloseClientConnections wait for conns to close

httptest.Server was rewritten during Go 1.6, but
CloseClientConnections was accidentally made async in the rewrite and
not caught due to lack of tests.

Restore the Go 1.5 behavior and add tests.

Fixes #14290
Updates #14291

Change-Id: I14f01849066785053ccca2373931bc82d78c0a13
Reviewed-on: https://go-review.googlesource.com/19432
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
src/net/http/httptest/server.go
src/net/http/httptest/server_test.go