]> Cypherpunks repositories - gostls13.git/commit
errors: record only single frame
authorMarcel van Lohuizen <mpvl@golang.org>
Wed, 13 Mar 2019 11:24:54 +0000 (12:24 +0100)
committerMarcel van Lohuizen <mpvl@golang.org>
Thu, 14 Mar 2019 09:31:05 +0000 (09:31 +0000)
commit5402854c3557f87fa2741a52ffc15dfb1ef333cc
tree82d254b3022d2de2c152a0f5cb751a0133d4fee8
parentb6fb6673bc1d132025b75fb6d3928775d959a8e3
errors: record only single frame

See Issue #29382 and Issue #30468.

3 frames are no longer needed as of
https://go-review.googlesource.com/c/go/+/152537/

name                     old time/op  new time/op  delta
New-8                     475ns ± 3%   352ns ± 2%  -25.87%  (p=0.008 n=5+5)
Errorf/no_format-8        661ns ± 4%   558ns ± 2%  -15.63%  (p=0.008 n=5+5)
Errorf/with_format-8      729ns ± 6%   626ns ± 2%  -14.23%  (p=0.008 n=5+5)
Errorf/method:_mytype-8  1.00µs ± 9%  0.84µs ± 2%  -15.94%  (p=0.008 n=5+5)
Errorf/method:_number-8  1.25µs ± 7%  1.04µs ± 2%  -16.38%  (p=0.008 n=5+5)

Change-Id: I30377e769b3b3be623f63ecbe365f8950ca08dda
Reviewed-on: https://go-review.googlesource.com/c/go/+/167400
Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
src/errors/frame.go
src/errors/frame_test.go