]> Cypherpunks repositories - gostls13.git/commit
crypto/ed25519: remove s390x KDSA implementation
authorMichael Munday <mike.munday@ibm.com>
Wed, 29 Jul 2020 13:02:56 +0000 (14:02 +0100)
committerFilippo Valsorda <filippo@golang.org>
Thu, 30 Jul 2020 16:00:05 +0000 (16:00 +0000)
commit54e75e8f9db09868db61f97edb98ace3aab7234f
treec5ab1dccedc191494088be51a42c5365a3aa32be
parent6b4dcf19fa493905689dedc27f2232b74c366057
crypto/ed25519: remove s390x KDSA implementation

This reverts CL 202578 and CL 230677 which added an optimization
to use KDSA when available on s390x.

Inconsistencies have been found between the two implementations
in their handling of certain edge cases. Since the Go 1.15 release
is extremely soon it seems prudent to remove this optimization
for now and revisit it in a future release.

Fixes #40475.

Change-Id: Ifb2ed9b9e573784df57383671f1c29d8abae90d4
Reviewed-on: https://go-review.googlesource.com/c/go/+/245497
Run-TryBot: Michael Munday <mike.munday@ibm.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ruixin(Peter) Bao <ruixin.bao@ibm.com>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
src/crypto/ed25519/ed25519.go
src/crypto/ed25519/ed25519_noasm.go [deleted file]
src/crypto/ed25519/ed25519_s390x.go [deleted file]
src/crypto/ed25519/ed25519_s390x.s [deleted file]
src/crypto/ed25519/ed25519_test.go