]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: fix large global variables in -linkshared mode on s390x
authorMichael Munday <mike.munday@ibm.com>
Wed, 20 Sep 2017 16:12:33 +0000 (12:12 -0400)
committerMichael Munday <mike.munday@ibm.com>
Wed, 20 Sep 2017 20:20:46 +0000 (20:20 +0000)
commit55ac5b50b079b14bcab4dc1a971d84516cd4bf75
tree6facc9b7abb7f124f73be0b9b8656d8abdb921bf
parent0d73f1e333bc9d0b0c07345efc498ebecaebf786
cmd/compile: fix large global variables in -linkshared mode on s390x

When rewriting loads and stores accessing global variables to use the
GOT we were making use of REGTMP (R10). Unfortunately loads and stores
with large offsets (larger than 20-bits) were also using REGTMP,
causing it to be clobbered and subsequently a segmentation fault.

This can be fixed by using REGTMP2 (R11) for the rewrite. This is fine
because REGTMP2 only has a couple of uses in the assembler (division,
high multiplication and storage-to-storage instructions). We didn't
use REGTMP2 originally because it used to be used more frequently,
in particular for stores of constants to memory. However we have now
eliminated those uses.

This was found while writing a test case for CL 63030. That test case
is included in this CL.

Change-Id: I13956f1f3ca258a7c8a7ff0a7570d2848adf7f68
Reviewed-on: https://go-review.googlesource.com/65011
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
misc/cgo/testshared/shared_test.go
misc/cgo/testshared/src/global/main.go [new file with mode: 0644]
misc/cgo/testshared/src/globallib/global.go [new file with mode: 0644]
src/cmd/internal/obj/s390x/objz.go