]> Cypherpunks repositories - gostls13.git/commit
[dev.unified] cmd/compile/internal/noder: add optExpr for optional expressions
authorMatthew Dempsky <mdempsky@google.com>
Fri, 3 Jun 2022 19:49:11 +0000 (12:49 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Mon, 6 Jun 2022 18:57:34 +0000 (18:57 +0000)
commit55fc07e16416bd3677c81bb6379ac8f9e881e5cf
treeb6f53bd3192e02308609dac1b88798b7bf948782
parent6c33f1d52efd4f70fb8cdb1c3b4ea1c8c579af2a
[dev.unified] cmd/compile/internal/noder: add optExpr for optional expressions

Previously, {writer,reader}.expr would allow for nil
expressions (i.e., no expression at all, not a "nil" identifier). But
only a few contexts allow this, and it simplifies some logic if we can
assume the expression is non-nil.

So this CL introduces optExpr as a wrapper method for handling nil
expressions specially.

Change-Id: I438bae7a3191126f7790ec0bf5b77320fe855514
Reviewed-on: https://go-review.googlesource.com/c/go/+/410099
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
src/cmd/compile/internal/noder/codes.go
src/cmd/compile/internal/noder/reader.go
src/cmd/compile/internal/noder/writer.go